Add better handling for native dropdowns #140
Merged
+116
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for doing this! could you add the role replacement functionality that was implemented in the typescript repo? here is the relevant file in the PR |
miguelg719
reviewed
Jul 14, 2025
| if node_role == "combobox": | ||
| node_role = "select" | ||
| node['role'] = node_role | ||
|
|
There was a problem hiding this comment.
we can't replace any combobox with select, in TS we do so conditionally with other heuristics. Checking if this replacement of roles is critical, if it is it's going to require a bigger pr separate to this to catch up with the new formatting of encoded ids in TS @Zach10za
There was a problem hiding this comment.
gonna push a patch and run evals
miguelg719
approved these changes
Jul 14, 2025
miguelg719
added a commit
that referenced
this pull request
Jul 14, 2025
* Add better handling for native dropdowns (#140) * Add better handling for native dropdowns * Update comment * Add role replacement * patch and changeset * clean up --------- Co-authored-by: Zach Loza <Zach10za@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better handling for native dropdowns. This feature was recently introduced in the JS repo: browserbase/stagehand#842 so this change is a simple port to python.
This should resolve this issue: #135
Why
Currently native os-level dropdowns are not able to be acted on. My understanding is these UI elements are rendered by the OS and are not part of the DOM which makes them invisible to playwright.
What changed
A straight port of the JS PR: browserbase/stagehand#842
TL;DR: Add a new method
selectOptionFromDropdownand instructions in the prompt for how to use it. The method uses Playwright'sselect_optionlocator method.Test plan
I ported over the test cases from the JS PR: